Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer run test suite without all the plugins because of warnings #4612

Closed
Cadair opened this issue Oct 29, 2020 · 10 comments · Fixed by #4596
Closed

Can no longer run test suite without all the plugins because of warnings #4612

Cadair opened this issue Oct 29, 2020 · 10 comments · Fixed by #4596
Labels
Tests Affects tests in some measure

Comments

@Cadair
Copy link
Member

Cadair commented Oct 29, 2020

This includes at least, doctestplus, asdf and remote-data

@dstansby
Copy link
Member

Why is this an issue? Is there an instance where one would want to (or expect to) run the test suite without all the test dependencies?

@Cadair
Copy link
Member Author

Cadair commented Oct 29, 2020

asdf is one of the things I wouldn't expect to have to be installed to run our tests, also we have code in conftest.py to handle a missing pytest-remotedata, so if that's not something we support anymore we should remove it.

@Cadair Cadair closed this as completed Oct 29, 2020
@Cadair Cadair reopened this Oct 29, 2020
@Cadair
Copy link
Member Author

Cadair commented Oct 29, 2020

Also see this fail on #4605 because you can't now run even the non-figure tests without pytest-mpl installed because we have some config option.

@nabobalis
Copy link
Contributor

I guess my question is, what do we want to happen by default?

Do we want for pytest to skip over test that require these plugins (in the same manner want to skip over submodules without deps installed)?

@Cadair
Copy link
Member Author

Cadair commented Oct 29, 2020

Maybe this is just expected, but it was jarring to me at least.

@nabobalis
Copy link
Contributor

Sure I think it is a bit jarring to run non-figure tests and have it error since pytest-mpl isn't installed.

I just am unclear on what we would like to be the default behaviour.

@dstansby
Copy link
Member

Can we just filter the appropriate warnings in setup.cfg?

@dstansby dstansby added the Tests Affects tests in some measure label Oct 30, 2020
@dstansby
Copy link
Member

Pretty sure this was fixed in the above PR, feel free to re-open if not the case.

@Cadair
Copy link
Member Author

Cadair commented Nov 18, 2020

Some of it but not all of it, I think it will still fail if asdf isn't installed, probably among others.

@Cadair Cadair reopened this Nov 18, 2020
@dstansby
Copy link
Member

I recently ran without asdf installed and it worked fine, and threw a warning at the end of the test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Affects tests in some measure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants