-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can no longer run test suite without all the plugins because of warnings #4612
Comments
Why is this an issue? Is there an instance where one would want to (or expect to) run the test suite without all the test dependencies? |
asdf is one of the things I wouldn't expect to have to be installed to run our tests, also we have code in conftest.py to handle a missing pytest-remotedata, so if that's not something we support anymore we should remove it. |
I guess my question is, what do we want to happen by default? Do we want for pytest to skip over test that require these plugins (in the same manner want to skip over submodules without deps installed)? |
Maybe this is just expected, but it was jarring to me at least. |
Sure I think it is a bit jarring to run non-figure tests and have it error since pytest-mpl isn't installed. I just am unclear on what we would like to be the default behaviour. |
Can we just filter the appropriate warnings in |
Pretty sure this was fixed in the above PR, feel free to re-open if not the case. |
Some of it but not all of it, I think it will still fail if asdf isn't installed, probably among others. |
I recently ran without asdf installed and it worked fine, and threw a warning at the end of the test run. |
This includes at least, doctestplus, asdf and remote-data
The text was updated successfully, but these errors were encountered: