Add tests for sunpy.physics.differential_rotate

[dipanshu231099]

Description

Previously the tests for differential rotation were only considering a new observer.
I have created tests for differential rotations as the time parameter is altered.

Fixes #3239

[dipanshu231099]

@nabobalis is it mergeable now ?

[nabobalis]

This needs two reviews from people who have worked on sunpy.physics.differential_rotate before it can be merged.

[wtbarnes]

So I know that this persisted prior to this PR, but it would be nice to break these tests up a bit. Rather than having one monolithic test_differential_rotate function, I'd prefer that we have a set of tests for this functionality.

As for the bits that test the time input, I think this could probably be parametrized, e.g. for a single function, the two possible input sets for observer and time could be ((new_observer, None), (None, new_time)).

[dipanshu231099]

So I know that this persisted prior to this PR, but it would be nice to break these tests up a bit. Rather than having one monolithic test_differential_rotate function, I'd prefer that we have a set of tests for this functionality.

As for the bits that test the time input, I think this could probably be parametrized, e.g. for a single function, the two possible input sets for observer and time could be ((new_observer, None), (None, new_time)).

shall i make a different test definition for time tests then ? @wtbarnes

[nabobalis]

Yes.

[wtbarnes]

So I know that this persisted prior to this PR, but it would be nice to break these tests up a bit. Rather than having one monolithic test_differential_rotate function, I'd prefer that we have a set of tests for this functionality.
As for the bits that test the time input, I think this could probably be parametrized, e.g. for a single function, the two possible input sets for observer and time could be ((new_observer, None), (None, new_time)).

shall i make a different test definition for time tests then ? @wtbarnes

Yes that'd be great! If you're interested in taking a stab at seeing how the existing test code could be broken up, that could make things a bit nicer as well, e.g. having separate tests for all on disk, partially on disk, all of disk.

[pep8speaks]

Hello @dipanshu231099! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-25 07:52:47 UTC

[dipanshu231099]

@wtbarnes i have segregated the different test blocks pre existing ones as well as new ones for the differential_rotate function

[dipanshu231099]

@wtbarnes any other thing required in it?

[nabobalis]

Thanks @dipanshu231099