Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need test for time input in differential rotation function #3239

Closed
wtbarnes opened this issue Jun 22, 2019 · 3 comments · Fixed by #4333
Closed

Need test for time input in differential rotation function #3239

wtbarnes opened this issue Jun 22, 2019 · 3 comments · Fixed by #4333
Labels
Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy physics Affects the physics submodule Priority Low Slow action required Tests Affects tests in some measure

Comments

@wtbarnes
Copy link
Member

Currently, the sunpy.physics.differential_rotate function is only tested for an input observer coordinate. There should also be a set of tests for a new obstime or time interval. This will avoid issues like #3189
@wtbarnes wtbarnes added Tests Affects tests in some measure physics Affects the physics submodule labels Jun 22, 2019
@nabobalis nabobalis added Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required labels Jun 22, 2019
@wtbarnes wtbarnes mentioned this issue Jun 27, 2019
Open
@dipanshu231099
Copy link
Contributor

i would like to work on this could you point me out to the right place in the codebase

@dipanshu231099
Copy link
Contributor

@nabobalis @wtbarnes

@nabobalis
Copy link
Contributor

Hi @dipanshu231099, you will need to add new tests to https://github.com/sunpy/sunpy/blob/master/sunpy/physics/tests/test_differential_rotation.py that call sunpy.physics.differential_rotate and change the obstime and the time inteveral of the rotate instead of just the frame used in the current tests.

@dipanshu231099 dipanshu231099 mentioned this issue Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy physics Affects the physics submodule Priority Low Slow action required Tests Affects tests in some measure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for sunpy.physics.differential_rotate dipanshu231099/sunpy
3 participants
@nabobalis @wtbarnes @dipanshu231099