fix: allow --paths-cmd to run on Windows #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
changed the title
justinchuby
force-pushed
the
justinchuby/windows2
branch
from
07558a0
to
71d30a9
Compare
7 tasks
|
@suo could you take a look? Thanks a lot! |
justinchuby
changed the title
justinchuby
changed the title
|
@suo could you release this too? Thanks a lot! |
|
Will do, probably wednesday (it's performance review season at work :P )
…On Mon, Jan 9, 2023 at 12:35 PM Justin Chu ***@***.***> wrote:
@suo <https://github.com/suo> could you release this too? Thanks a lot!
—
Reply to this email directly, view it on GitHub
<#23 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK4EBIPE2U52V2Z6AZ233WRRZA7ANCNFSM6AAAAAASRBRACM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
this done, and I added a script so I can do it right after merging in the future 😛 |
|
Looks like the version number in cargo.toml needs increment? |
|
dammit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
get_paths_from_cmdto run the command directly instead of using shell to run the command.fixes #22