Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix: email redirect #92

Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix: email redirect #92

merged 2 commits into from
Oct 21, 2022

Conversation

Vinzent03
Copy link
Contributor

@Vinzent03 Vinzent03 commented Oct 20, 2022 •
edited
Loading

@Vinzent03
Copy link
Contributor Author

In addition, I noticed now that body in request is unused. Should we remove it or use it if options.body is null? Why even both?

dshukertjr
dshukertjr approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! Yup, I must have left the body by mistake. Let's remove it all together from the request() method.

dshukertjr
dshukertjr approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the super quick fix!

@dshukertjr dshukertjr merged commit c3b26dc into main Oct 21, 2022
@dshukertjr dshukertjr deleted the fix/redirect branch October 21, 2022 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with redirect url in v1.0.0
2 participants
@Vinzent03 @dshukertjr