Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use api_external_url domain as localname #1575

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: use api_external_url domain as localname #1575

merged 1 commit into from
May 8, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Fixes an issue where some SMTP providers reject requests when the SMTP client uses a Local Name that is identical to the SMTP Host name.

@kangmingtay kangmingtay requested a review from a team as a code owner May 8, 2024 05:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8996563068

Details

  • 1 of 9 (11.11%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 65.472%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/mailer/mailer.go 1 9 11.11%
Totals Coverage Status
Change from base Build 8996091849: -0.002%
Covered Lines: 8366
Relevant Lines: 12778
💛 - Coveralls

@kangmingtay kangmingtay merged commit ed2b490 into master May 8, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/update-mailme branch May 8, 2024 05:58
@github-actions github-actions bot mentioned this pull request May 8, 2024
Merged
J0 pushed a commit that referenced this pull request May 22, 2024
@github-actions
chore(master): release 2.152.0 (#1574)
b954a48 
🤖 I have created a release *beep* *boop*
---


##
[2.152.0](v2.151.0...v2.152.0)
(2024-05-22)


### Features

* new timeout writer implementation
([#1584](#1584))
([72614a1](72614a1))
* remove legacy lookup in users for one_time_tokens (phase II)
([#1569](#1569))
([39ca026](39ca026))
* update chi version
([#1581](#1581))
([c64ae3d](c64ae3d))
* update openapi spec with identity and is_anonymous fields
([#1573](#1573))
([86a79df](86a79df))


### Bug Fixes

* improve logging structure
([#1583](#1583))
([c22fc15](c22fc15))
* sms verify should update is_anonymous field
([#1580](#1580))
([e5f98cb](e5f98cb))
* use api_external_url domain as localname
([#1575](#1575))
([ed2b490](ed2b490))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @J0