Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TikTok OAuth Provider #199

Closed
chimon2000 opened this issue Sep 2, 2021 · 6 comments
Closed

TikTok OAuth Provider #199

chimon2000 opened this issue Sep 2, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@chimon2000
Copy link

Feature request

Create an OAuth provider for TikToke

TikTok recently published their OAuth flow
https://developers.tiktok.com/doc/login-kit-web

Is your feature request related to a problem? Please describe.

For the application that I am working on, we convert users from TikTok. Currently, we plan to authenticate them from using Phone authentication, but TikTok support could drastically improve our conversion.

Describe the solution you'd like

Social login with TikTok is supported similar to existing 3rd party providers.

Describe alternatives you've considered

The only other alternative would be to host our own authentication server and use it in tandem with Supabase. Not particularly ideal.

Additional context

n/a

@chimon2000 chimon2000 added the enhancement New feature or request label Sep 2, 2021
@HarryET
Copy link
Contributor

HarryET commented Oct 22, 2021

Was just looking into PRing this in but found that Login Kit doesn't provide email. So I'm not sure how it would work with the other providers all supporting emails. Might be something the supabase team needs to comment on.
https://developers.tiktok.com/doc/manage-user-access-tokens

@chimon2000
Copy link
Author

I imagine this would be fine since Phone Number authentication does not provide an email, but probably good to get some feedback from the team.

cc @kiwicopple

@HarryET
Copy link
Contributor

HarryET commented Oct 25, 2021

I imagine this would be fine since Phone Number authentication does not provide an email, but probably good to get some feedback from the team.

cc @kiwicopple

Yeah, the bigger issue is there is no contact info, just username and tiktok id

@kangmingtay
Copy link
Member

Hey @HarryET, @chimon2000, we have actually stopped using the email from the oauth provider as the primary identifier for a user. The current list of providers still check if a new user / existing user has an email associated with their provider account but we haven't got to refactoring that bit yet. For the TikTok oauth provider implementation-wise, the response needs to contain the open_id field since that's TikTok's way of uniquely identifying a user.

@HarryET
Copy link
Contributor

HarryET commented Oct 29, 2021

Hey @HarryET, @chimon2000, we have actually stopped using the email from the oauth provider as the primary identifier for a user. The current list of providers still check if a new user / existing user has an email associated with their provider account but we haven't got to refactoring that bit yet. For the TikTok oauth provider implementation-wise, the response needs to contain the open_id field since that's TikTok's way of uniquely identifying a user.

That's awesome! I'll try get a PR open today for TikTok

@J0
Copy link
Contributor

J0 commented Apr 19, 2022

Duplicate of #451

@J0 J0 marked this as a duplicate of #451 Apr 19, 2022
@J0 J0 closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants