Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always redirect back to user site for recovery/magic link #39

Closed
thorwebdev opened this issue Nov 17, 2020 · 3 comments
Closed

Always redirect back to user site for recovery/magic link #39

thorwebdev opened this issue Nov 17, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@thorwebdev
Copy link
Member

Feature request

Currently, if a recovery/magic link is expired, supabase will show a json error which is not a good user experience. Rather we should redirect back to the merchant site with an error_description URL param maybe?

Additional context

Add any other context or screenshots about the feature request here.
image

@thorwebdev thorwebdev added the enhancement New feature or request label Nov 17, 2020
@icecream78
Copy link
Contributor

@awalias is this good enough improvement according to UX?

@awalias
Copy link
Member

awalias commented Nov 20, 2020

perhaps we should have <USER-SITE>#auth_error_code=404&auth_error_message=user%20not%20found as the query params, just because some webs apps may already use the error-XXX query param

actually as pointed out by thor, gotrue already has a concept of error_description

lets do <USER-SITE>#error_code=404&error_description=user%20not%20found

but yes agreed that we should redirect back to user site 👍 nice suggestion @thorwebdev

@awalias
Copy link
Member

awalias commented Mar 10, 2021

closing this but noting that still need to solve for signup: supabase/supabase#504

@awalias awalias closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants