-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure ID Error #1274
Comments
I see the same thing. I think its has to do with appending"2.0" to the issuer, but I don't have a good way to verify: Docs state to omit that for Active directory 1.0 apps: https://learn.microsoft.com/en-us/azure/container-apps/authentication-azure-active-directory Our app has been down for our users, hopefully this gets resolved soon. |
@hf was there a deploy for Supabase auth related to the changes you made yesterday? I don't know where to check, but I saw you merged in some changes to gotrue that seem related? |
It seems we're hitting this error: https://github.com/supabase/gotrue/pull/1269/files#diff-ea3c11f35c15f1496340532424b81c805cc3f6fb541800add5cd6f497548b324R130. I believe the changes here should have fixed it: https://github.com/supabase/gotrue/pull/1272/files, but I'm still seeing this error in production. @hf given this is affecting production customers, it would be great to know if your team can act on this asap. |
@mosnicholas not sure if your situation allows, but I was able to resolve my issue by switching my from Azure Tenant URL from: https://login.microsoftonline.com/organizations to https://login.microsoftonline.com/common see the following for info: I was also required to add email to the login scope: ... = await supabase.auth.signInWithOAuth({ |
Thank you for updating here @aaron-xandria |
## What kind of change does this PR introduce? * The issuer can also be https://login.microsoftonline.com/organizations for applications processing accounts in any organizational directory (any Microsoft Entra directory) (see [here](https://learn.microsoft.com/en-us/azure/active-directory/develop/howto-convert-app-to-be-multi-tenant)) * Fixes #1274
hey everyone, we've fixed this issue in #1275 and will roll it out to all affected projects on Supabase. |
🎉 This issue has been resolved in version 2.104.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…1275) ## What kind of change does this PR introduce? * The issuer can also be https://login.microsoftonline.com/organizations for applications processing accounts in any organizational directory (any Microsoft Entra directory) (see [here](https://learn.microsoft.com/en-us/azure/active-directory/develop/howto-convert-app-to-be-multi-tenant)) * Fixes supabase#1274
Bug report
As of
2023-10-17T08:59:15.000Z
, I have started seeing the following errors in my Azure auth:Describe the bug
Azure login in is no longer working for my multitenant app. It might be related to this: #1269.
To Reproduce
I'm not sure -- i haven't changed anything in my app since yesterday and started seeing these errors.
Expected behavior
There should be no errors.
Screenshots
If applicable, add screenshots to help explain your problem.
System information
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: