feat: add POC for custom SMS sender Hook #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 13, 2023 16:37
J0
commented
Oct 20, 2023
| type CustomSMSHookResponse struct { | ||
|
|
||
| // API Version | ||
| ApiVersion string `json:"api_version"` |
There was a problem hiding this comment.
generated via the CLI tool
J0
commented
Oct 30, 2023
| id uuid not null, | ||
| uri text not null, | ||
| event_name text not null, | ||
| secret text not null, |
There was a problem hiding this comment.
Should be changed to parse a comma separated string
|
Closing since it's not relevant for now. We are moving to PostgreSQL hooks |
J0
added a commit
that referenced
this pull request
Feb 19, 2024
## What kind of change does this PR introduce? Adds configuration for HTTPS hooks as well as the validation checks for configuration. - Follow up to SQL Hooks like in #1328 - Successor to #1246 Relevant section of the specification [is here](https://github.com/standard-webhooks/standard-webhooks/blob/main/spec/standard-webhooks.md#signature-scheme). Event names will be introduced closer to completion Co-authored-by: joel <joel@joels-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We modify the existing webhook implementation to work for Auth Hooks. The implementation largely follows Auth Hooks and has the following key points:
hooks_configtable