feat: initial fix for invite followed by signup. #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2023 16:42
J0
commented
Oct 3, 2023
hf
approved these changes
Oct 9, 2023
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
J0
changed the title
|
🎉 This PR is included in version 2.100.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
hoeseong19
pushed a commit
to hoeseong19/gotrue
that referenced
this pull request
Oct 16, 2023
## What kind of change does this PR introduce? Currently, sending an `invite` request followed by a `signup` request w/o confirmation between invite and signup will expose metadata on UserMetadata and Identities which may be perceived as a leak of sensitive information. This PR aims to clear out such metadata for cases where the dev has been invited before a signup ## Testing Instructions How to test locally: Use this admin bearer `jwt` 1. Call http://localhost:9999/invite to `myemail@gmail.com` 2. Wait 60s 3. Call http://localhost:9999/signup with `myemail@gmail.com` and check that `identities` field is blanked out --------- Co-authored-by: joel@joellee.org <joel@joellee.org> Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, sending an
inviterequest followed by asignuprequest w/o confirmation between invite and signup will expose metadata on UserMetadata and Identities which may be perceived as a leak of sensitive information.This PR aims to clear out such metadata for cases where the dev has been invited before a signup
Testing Instructions
How to test locally:
Use this admin bearer
jwtmyemail@gmail.commyemail@gmail.comand check thatidentitiesfield is blanked out