Prevent empty results when selecting folder(s) in one bucket that match an object name in another bucket #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er(s) in one bucket that match an object name in another bucket
inian
approved these changes
Oct 11, 2021
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a bucket "a" and an object name "123/456", and a bucket "b" and an object/folder name "123", when selecting bucketname="a" and prefix="":
Before the fix:
If the latter doesn't exist, a row with only name="123" populated and the other columns being NULL is returned.
If the latter exists, name="123" is left joined with the row with object/folder name "123", and then filtered out by the
WHERE ... objects.bucket_id=bucketnameclause.After the fix:
The row with object/folder name "123" isn't left joined, so a row with only name="123" populated and the other columns being NULL is returned correctly.