fix: token refresh doesn't block on ClientException #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
What is the current behavior?
When the device is offline the
refreshSessiontakes very long until all retry attempts are done. This may be unexpected and blocks everything when awaited, as seen when usingSupabase.initialize(). Additionally, postgrest requests now properly fail with aClientExceptionwhen being offline and not waiting endless when access token is expired.What is the new behavior?
refreshSessionfinishes after the first requests and throws when request fails. The refresh token timer is started in the background and emits a valid session to theonAuthStateChangestream when available.Additional context
This is hopefully the last pr to that refresh token offline issue...
close #630