Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle component has excess spacing #45

Closed
joshenlim opened this issue Jan 9, 2021 · 11 comments · Fixed by #67
Closed

Toggle component has excess spacing #45

joshenlim opened this issue Jan 9, 2021 · 11 comments · Fixed by #67
Labels
bug Something isn't working released

Comments

@joshenlim
Copy link
Member

joshenlim commented Jan 9, 2021

Bug report

Similar to the previous Button component issue, Toggle has excess spacing from probably from a gap-x-{n} class

image

@joshenlim joshenlim added the bug Something isn't working label Jan 9, 2021
@MildTomato
Copy link
Contributor

@joshenlim can you paste in Toggle code your using in here?

and are you using latest version of @supabase/ui?

@MildTomato
Copy link
Contributor

I can't recreate this, I think it was fixed in a previous release, -> #40

@joshenlim just reopen it if the problem persists on latest version of lib

@joshenlim
Copy link
Member Author

oh sorry for getting back late! I'm using the Toggle as such without any labels, still has the excess spacing - I'm thinking its cause i'm not giving the toggles any labels?
image

@MildTomato
Copy link
Contributor

@joshenlim what version you using?

@joshenlim
Copy link
Member Author

this is 0.1.19

@MildTomato
Copy link
Contributor

thanks ill look into it 👍

@MildTomato MildTomato reopened this Jan 11, 2021
@MildTomato
Copy link
Contributor

@joshenlim i still can't recreate this anywhere.

maybe best i jump in your project and see what's going on.
got a link to branch/repo ?

@joshenlim
Copy link
Member Author

@MildTomato
Copy link
Contributor

MildTomato commented Jan 13, 2021

Screenshot 2021-01-13 at 14 05 03

I can't recreate this. are you sure?

This is in surf repo, in the login feature branch

@MildTomato
Copy link
Contributor

thanks @joshenlim for helping before.

the spacing on the right due the layout of the toggle, its always left aligned with text/labels.
this will show the label/text aligned on one side, while the toggle is aligned on the opposite side - which is what it should of been anyway 🙈

I'll also leave support for the horizontal layout as well on top of that, incase we wanted it to sit inside a horizontal form, which has the labels on the left in another column.

I'll get that implemented!

@kiwicopple
Copy link
Member

🎉 This issue has been resolved in version 0.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants