Refactoring writing server-sent events in a raw format. #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://superagent-pr-932.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co7dg9uv3ddc73cbvm8g. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
homanp
reviewed
Apr 4, 2024
There was a problem hiding this comment.
@elisalimli looks good, would this require any change in the UI?
No, it would not. |
homanp
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors writing server-sent events in a raw format. Instead, now we are writing python dictionary and stream its keys and valuse. It's more easy to maintain and write.