-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand shell commands #54
Comments
It looks like we need to escape character's ourselves. Instead of worrying about "undoing" the escaping of characters written in a TOML string, we can just use raw TOML strings, which are strings with single quotes ( We can then write a program to recognize This is a breaking change. We can't really do that much about this. We could try to detect the type of quotations that are used, but that would involve parsing the file and might trigger some false positives (this might be worth it though, if we state that these false positives can happen). Otherwise, the documentation should be changed to use single quotes, and it should be directly stated that using double quotes requires double escaping. |
However, this finally allows us to implement this feature! When this is completed, we can also easily finish the rest of #38. |
To be able to issue warnings, we can read through each line of the file and scan for any line that matches |
Also note that the use of double quotes with never be removed, just discouraged for most use cases. This is because after this issue is implemented and merged the new behavior will normally result in having to double escape backslashes while using double quotes. The warning will either be downgraded it severity or removed in a future version a significant amount of time after the changes in this issue are made. This will probably happen in |
This is a workaround until superatomic/xshe#54 is implemented for `xshe`.
Update: Warnings will not be issued as that could affect actual use cases. |
Part of #38.
We need to specially handle the
$(shell command)
syntax.Details:
)
character to be able to use them inside of the expression.$
to not expand it. This is also relevant to Expand shell variables #53.The text was updated successfully, but these errors were encountered: