set first sample of output in Ctor #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say, include those fixes here. If the issue and solution are known, there's no need for a separate PR. Thanks! |
|
(deleted a comment which was based on a misunderstanding) |
|
done |
|
Is somebody going to review? |
|
3.10.0-rc1? |
nhthn
requested changes
Nov 15, 2018
|
@snappizz I dont undestand why There are jeckill failures on travis (not related to this PR) |
joshpar
approved these changes
Jan 14, 2019
patrickdupuis
added a commit
that referenced
this pull request
Feb 25, 2019
Cherry-pick #223 onto 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly solves #214
Also need that in DWGBowed , DWGPlucked and OteyPianoUGens. Shall I wait for this commited or include changes in this PR?