SCLang: Too many args passed to certain 'inlined' methods

[JordanHendersonMusic]

Purpose and Motivation

When the compile/parser see a method with only a single call, or a call to super.something, it 'inlines' it.

For these methods, all the user's arguments were being passed through, regardless of how many were declared in the function signature.

This commit checks this, and removes any excess args from the stack.

Fixes #1087

Here is some code to demonstrate the error, before this commit, b and c would be set.

TestCopyArgs {
    var a, b, c;
    *new { |a| ^super.newCopyArgs(a) }
}

TestCopyArgs(\a, \b, \c).dump

Types of changes

• Bug fix

This should not break any code, and if it does, that code is wrong.

To-do list

• Code is tested
• All tests are passing
• Appeasing the linter
• This PR is ready for review

[telephon]

Perhaps you could add a test that checks that correct ellipsis argument passing (still) works, too:

TestCorrectArgCountObj {
	var <a, <b, <c;
	*new {|...a| ^super.newCopyArgs(a) }
}

should make a == [\a, \b, \c] and b = c = nil.

And

TestCorrectArgCountObj {
	var <a, <b, <c;
	*new {|...a| ^super.newCopyArgs(*a) }
}

should make a = \a, b = \b, c = \c as expected.

[JordanHendersonMusic]

@telephon all done.

[capital-G]

Bump @telephon