Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-1172] Repeat summary for recurring events #190

Merged
merged 1 commit into from
May 8, 2017
Merged

[SDESK-1172] Repeat summary for recurring events #190

merged 1 commit into from
May 8, 2017

Conversation

nrvikas
Copy link
Contributor

@nrvikas nrvikas commented May 2, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 89.092% when pulling b1e86c5 on nrvikas:SDESK-1172 into 986ed3b on superdesk:master.

vied12
vied12 reviewed May 4, 2017
View reviewed changes
Copy link
Contributor

@vied12 vied12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool !
I would just move this feature to a dedicated component in order to isolate it and to simplify the tests

@nrvikas
[SDESK-1172] Repeat summary for recurring events
4e94be4 
[SDESK-1172] Test case fix

[SDESK-1172] Changes after review
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 89.221% when pulling 4e94be4 on nrvikas:SDESK-1172 into dc2c223 on superdesk:master.

@nrvikas
Copy link
Contributor Author

nrvikas commented May 7, 2017

@vied12 , thanks for your feedback. I have updated the PR with a new component.
Thanks.

@vied12 vied12 merged commit 83e65f0 into superdesk:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vied12 vied12 vied12 approved these changes

@thnkloud9 thnkloud9 thnkloud9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrvikas @coveralls @vied12 @thnkloud9