Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncordon endpoint and description of a bluegreen deployment. #1217

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

asib
Copy link
Contributor

@asib asib commented Nov 30, 2023

Summary of changes

The endpoint for uncordon was wrong. Also noticed that the description for a bluegreen deployment isn't quite right, since we don't update existing machines in a bluegreen deployment (see linked doc).

Related Fly.io community and GitHub links

Notes

n/a

@asib asib requested a review from andie787 November 30, 2023 13:05
Copy link
Contributor

@andie787 andie787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for finding and fixing! lgtm!

@asib asib merged commit e81cf4d into main Nov 30, 2023
3 checks passed
@asib asib deleted the jfent/uncordon-endpoint branch November 30, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants