Request headers: update to correct inaccurate info about client IP #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andie787
commented
Jul 25, 2024
PeterCxy
reviewed
Jul 25, 2024
PeterCxy
reviewed
Jul 25, 2024
|
@PeterCxy thanks for your review; took all your suggestions! |
PeterCxy
reviewed
Jul 25, 2024
|
@PeterCxy also a question: "On the Fly.io platform, the last address in this list will be a shared or dedicated IP address assigned to your app." Is this the leftmost? I had assumed rightmost at first based on "last" |
|
@andie787 It's the rightmost. I believe all proxies are supposed to add their own addresses to the very end of that list (i.e. right). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fly-Client-IPto clarify what happens when you use a proxy, and to link to to theX-Forwarded-FordescriptionX-Forwarded-Forfor clarify why you want to go read the MDN docsPreview
Related Fly.io community and GitHub links
Notes