Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when building with go 1.21 #2727

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix error when building with go 1.21 #2727

merged 1 commit into from
Aug 22, 2023

Conversation

michaeldwan
Copy link
Contributor

@michaeldwan michaeldwan commented Aug 22, 2023 •
edited
Loading

Fixes #2688

@michaeldwan michaeldwan changed the title go 1.21 Fix error when building with go 1.21 Aug 22, 2023
@michaeldwan michaeldwan marked this pull request as ready for review August 22, 2023 18:33
dangra
dangra approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes tests under Go 1.20.0 which is as good, but shouldn't it be bumping the Go version we use to build, test and release too?

@michaeldwan
Copy link
Contributor Author

@dangra This just lets us build using 1.21, and I have another branch that actually targets go 1.21. It works fine, but after #2640 I'd like to test it more thoroughly since github.com/docker/docker is still targeting go 1.20.

@michaeldwan michaeldwan merged commit 843389d into master Aug 22, 2023
19 of 20 checks passed
@michaeldwan michaeldwan deleted the upgrade-go branch August 22, 2023 22:13
@stefanb stefanb mentioned this pull request Dec 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangra dangra dangra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support go1.21.0
2 participants
@michaeldwan @dangra