-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petarbaykov
commented
Mar 11, 2020
•
edited
Loading
edited
- aex2.js spec sometimes pass and sometime not (I think is problem with cypress) and runs only in headed browser
- names and settings pages don't have tests, because I am not sure if the UI will remain the same (currently is same as waellet UI)
* Send INIT_RPC message only if IS_EXTENSION * Test cases for import account page * Add more cy commands
* Run build before start tests * Cleanup cypress config
…ate more commands for menu iteraction
* Increase cypress getting element timeout * Amount send more tests * More tests cases for tip page
* Extract some helpers function in file so they can be tested or reused in tests * Test cases for pending txs * Test cases for last visited route
* Extract mock login method for reuse in tests and extension * Create build folder for extension that will run in tests browser * Load extension before in tests browser before browser is started
mradkov
approved these changes
Mar 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this initial test coverage!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.