Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pika icon shows on top of Apple menu after restart when set to "Hide menu bar icon" #108

Closed
bikrrr opened this issue Sep 30, 2023 · 18 comments
Labels
bug Something isn't working
Milestone

Comments

@bikrrr
Copy link
Contributor

bikrrr commented Sep 30, 2023

Describe the bug
Restarting Pika or macOS will result in the Pika menu bar icon displaying on top of the Apple menu icon in the upper-left corner of the display.

To Reproduce
Prerequisites:
Launch at login: Enabled
Hide menu bar icon: Enabled
App Settings: Menu bar

Steps to reproduce the behavior:

  1. Restart macOS -OR- quit & restart Pika
  2. View the left side of the menu bar

Expected behavior
No Pika menu bar icon would be visible.

Screenshots
Pika Menu Bar Icon Visible

Pika Settings For Repro

Environment (please complete the following information):

  • OS: 14.0 (23A344) aka, Sonoma
  • App Version: 0.0.15
  • Architecture: Apple Silicon

Additional context
I actually saw a variation of this on Ventura, where the icon would display further down the display's left edge, but it was sporadic so I never logged it.

@bikrrr bikrrr added the bug Something isn't working label Sep 30, 2023
@bikrrr
Copy link
Contributor Author

bikrrr commented Sep 30, 2023

I should add that toggling Hide menu bar icon off and on again in Pika Preferences, will fix it until the next restart.

@jhil
Copy link

jhil commented Oct 1, 2023

Thanks! I also have this issue. Also, sometimes it shows up about halfway down my screen (but still on the far left edge). Let me know if I can help with more repro details.

Screenshot 2023-10-01 at 16 30 26

@superhighfives
Copy link
Owner

Finally getting around to taking a look at this bug, and I'm struggling to reproduce it. Out of curiosity, which laptop are you using? Does it have a notch? Thanks so much for reporting!

@bikrrr
Copy link
Contributor Author

bikrrr commented Oct 11, 2023

Hey, Charlie!

I'm seeing it on a 2021 14" MacBook Pro (has a notch) on Sonoma 14.0 (23A344). It happens both on the MacBook display and when extended to an Apple Studio Display, even with the laptop in clamshell mode (closed).

@jhil
Copy link

jhil commented Oct 11, 2023

Apple M1 Max, 14 inch with notch, macos 14.0 (23A344)

@3x3cut0r
Copy link

3x3cut0r commented Oct 12, 2023

MacMini M2, external monitor with of course no notch. macos 14.0.

@aguilaair
Copy link

M1 MBP 2021 16" on Sonoma 14.1 Beta (23B5067a)

@Sydnxt
Copy link

Sydnxt commented Oct 15, 2023

M2 MAX MBP 2023 16" on Sonoma 14.1 Beta (23B5067a)

@nidhin-locale
Copy link

I have the same issue, except mine refuse to go away even set it to show on dock.
Using 2020 m1 macbook air, with macos 14.0

Screenshot 2023-10-25 at 22 42 24

@nidhin-locale
Copy link

nidhin-locale commented Oct 31, 2023

It is possible to move the icon from the top left with "cmd + drag", but does not snap with other icons on the menu bar.

Uploading Screen Recording 2023-10-31 at 16.49.09.mp4…

@superhighfives
Copy link
Owner

Really struggling to recreate this one consistently, but still looking into it. Thanks for all the context, and if there are any specific steps that consistently recreate the issue, please let me know. Also @nidhin-locale, it looks like the video you share didn't upload successfully.

bikrrr added a commit to bikrrr/pika that referenced this issue Nov 8, 2023
…tes the error when making statusBarItem key, since it's an NSStatusItem and can't become key. This fixes issue superhighfives#108 - Pika icon shows on top of Apple menu after restart when set to "Hide menu bar icon".
@bikrrr
Copy link
Contributor Author

bikrrr commented Nov 8, 2023

@superhighfives I just submitted a pull request, which (I think) fixes the issue. I tested it on both an Apple Silicon and Intel Macs and worked properly on both (no more errant Pika menubar icons).

This is my first pull request so hopefully, I did it right?! 🤞😅

@superhighfives
Copy link
Owner

Awesome, perfect PR @bikrrr—really appreciate it! 😊 Aiming to release a beta for this and Spanish localisation this week.

@bikrrr
Copy link
Contributor Author

bikrrr commented Nov 13, 2023

Cool. Since you're working on localization, do you plan to update the Preferences... menu item to Settings... to match macOS's latest standard (link)? And possibly add command comma (⌘+,) as the shortcut (link)?

If not, that's okay. I wouldn't mind trying another PR…I could use the practice! :)

@superhighfives
Copy link
Owner

Ah, good catch, @bikrrr! I can definitely make that change as part of 0.0.16, but if you'd like to take a pass at the PR for practice you're more than welcome. Let me know what you'd prefer.

superhighfives pushed a commit that referenced this issue Nov 13, 2023
…tes the error when making statusBarItem key, since it's an NSStatusItem and can't become key. This fixes issue #108 - Pika icon shows on top of Apple menu after restart when set to "Hide menu bar icon". (#111)
@bikrrr
Copy link
Contributor Author

bikrrr commented Nov 13, 2023

Why don't you make the change?

I still have a lot to do on a personal project. Maybe in a while when I need a change of scenery, I can try my hand at another Pika issue!

@superhighfives
Copy link
Owner

Awesome, sounds good @bikrrr. Will do. 👍

@superhighfives
Copy link
Owner

This is now released as 0.0.16-beta1, which you can access by downloading it from https://github.com/superhighfives/pika/releases/tag/0.0.16-beta1, or by checking "Subscribe to beta releases" in Pika's settings and then "Check for updates..." in the menu. Thanks @bikrrr, ya superhero!

Any feedback or issues, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants