Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate local chrome wrapper to use puppeteer #29

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Migrate local chrome wrapper to use puppeteer #29

merged 6 commits into from
Aug 22, 2022

Conversation

Hehk
Copy link

@Hehk Hehk commented Jul 27, 2022

  • integrate the chrome wrapper into server
  • Almost entirely lift and shift, the only extra in _retryOnClose

Hehk added 4 commits July 27, 2022 10:40
@Hehk
Migrate local chrome wrapper to use puppeteer
89486cf 
- integrate the chrome wrapper into server
- Almost entirely lift and shift, the only extra in _retryOnClose
@Hehk
Get remote puppeteer working
96e367a 
- added launchLambda fn
- Re-implement the network intercept to work with puppeteer
- Temporary changes to lambda name to use the new code
@Hehk
Remove artifacts of the old chrome implementation
f794929
@Hehk
Fix issues with running on remote
3e6041d 
- wire up the page resize fn
- Add more flags that reduce the requirements of chromium
@Hehk Hehk marked this pull request as ready for review August 4, 2022 15:36
@Hehk Hehk requested a review from zindlerb August 11, 2022 15:02
zindlerb
zindlerb approved these changes Aug 17, 2022
View reviewed changes
Copy link

@zindlerb zindlerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From testing locally I saw some tests that failed on remote but passed locally. But I think I was seeing that before so that might not be a regression. But it seems to work well besides that.

@Hehk Hehk merged commit 3f411fe into master Aug 22, 2022
@Hehk Hehk deleted the puppeteer branch August 22, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zindlerb zindlerb zindlerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hehk @zindlerb