Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] Numbered list doesn't work on manual addition of items and when number is not 1 #1894

Closed
alterhuman opened this issue Mar 13, 2024 · 6 comments · Fixed by #2061
Assignees
Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 5 type_enhancement New feature or request

Comments

@alterhuman
Copy link

alterhuman commented Mar 13, 2024

If you type

1. List Item

and press enter/return, the result is as follows:

1. List Item
2. 

This is correct behaviour. But if you type:

1. List Item

and then manually enter 2. below it, the attribution doesn't change.
Ideally it should change it to the second list item, resulting in:

1. List Item
2. 

In some text editors, even typing any other number other than one greater than the previous list item, changes the list item correctly. For example,
if you type:

1. List Item

and then manually enter 4. below it, it changes it to:

1. List Item
2. 

Video Example

Screen.Recording.2024-03-13.at.8.30.45.PM.mov

Related Issue

If you type 1. , it changes to list attribution, but typing any other number 2. or 12. etc. doesn't change the attribution to numbered list attribution.

Ideally it should start a list from that very number. For example, 2. should start a list from 2.

Screen.Recording.2024-03-13.at.8.33.27.PM.mov
@alterhuman alterhuman added the type_bug Something isn't working label Mar 13, 2024
@alterhuman
Copy link
Author

cc: @rutvik110, @angelosilvestre

@rutvik110
Copy link
Collaborator

rutvik110 commented Mar 18, 2024

@alterhuman The example demos you shared, which app are they captured from?

@rutvik110 rutvik110 added type_enhancement New feature or request area_supereditor Pertains to SuperEditor and removed type_bug Something isn't working labels Mar 18, 2024
@alterhuman
Copy link
Author

@rutvik110 this is Bear app. Similar behaviour is present in Apple Notes too.

@rutvik110
Copy link
Collaborator

Tested this across google docs as we're trying to follow it for certain editor features and their behaviours. I can see some of the things you mentioned are supported in google docs and there are few key differences between how Super Editor vs google docs work with numbered lists.

@matthew-carroll We probably wanna re-visit how Super Editor handles numbered list and try to match the google docs experience for them. Though this missing behaviours aren't critical enough for us to work on this immediately but nice to have improvements that we can work on later down the line.

@matthew-carroll
Copy link
Contributor

@miguelcmedeiros @brian-superlist - Can you two let us know if this is a desirable default behavior? It seems like a fine thing to support, but we don't want to make it the default if you don't want it.

@brian-superlist
Copy link
Contributor

Yes, this makes sense for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time: 5 type_enhancement New feature or request
Projects
None yet
5 participants