-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuperTextField][iOS] Fix toolbar arrow direction (Resolves #1094) #1099
[SuperTextField][iOS] Fix toolbar arrow direction (Resolves #1094) #1099
Conversation
MaterialApp( | ||
debugShowCheckedModeBanner: false, | ||
home: Scaffold( | ||
body: Stack( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using a Stack
to display a single child
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just to use the Positioned
widget to place the textfield at the bottom of the screen.
super_editor/test_goldens/super_textfield/super_textfield_toolbar_test.dart
Show resolved
Hide resolved
super_editor/test_goldens/super_textfield/super_textfield_toolbar_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[SuperTextField][iOS] Fix toolbar arrow direction. Resolves #1094
On iOS, the textfield toolbar is always pointing up, even when it's positioned above the text field.
The cause is that we are passing local offsets to
overlayController
, which expects global offsets.This PR changes the iOS editing controls to pass global offsets and adds golden tests.
I noticed we have golden tests for super_textfield in the "test" dir instead of "test_goldens" (it seems it was my fault). I moved those tests to "test_goldens" dir.