[SuperEditor] Avoid restoring selection upon re-focus when selected nodes were deleted (Resolves #1074) #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes were deleted (Resolves superlistapp#1074)
angelosilvestre
added a commit
to angelosilvestre/super_editor
that referenced
this pull request
Apr 26, 2023
…odes were deleted (Resolves superlistapp#1074) (superlistapp#1103)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Avoid restoring selection upon re-focus when selected nodes were deleted. Resolves #1074
EditorSelectionAndFocusPolicyrestores the previous selection when the editor re-gains focus. If the node at the selection base or extent was removed while the editor didn't have focus, restoring the selection causes the editor to crash, because we are applying a selection with an inexistent node.This PR changes
EditorSelectionAndFocusPolicyto check if the nodes at base and offset are still present before restoring the selection.