[SuperEditor][Android] Fix scrolling when dragging at empty space (Resolves #2001) #2037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][Android] Fix scrolling when dragging at empty space. Resolves #2001
When the user drags starting from an empty space, for example, the area of the document padding, the following crash happens and the editor does not scroll:
The root cause is that, when we check if the user tapped over the caret, we assume that the tap down position can always be mapped to a
DocumentPosition
, which isn't the case. This only happens if the editor has a collapsed selection.This PR fixes the issue and adds test for scenarios with collapsed selection, expanded selection and no selection.