[SuperTextField] Re-generate failing caret test goldens (Resolves #2085) #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
On this one it seems like maybe we lost the caret off to the left. Can you check, for example, where the caret appears on the left side of an image when the image takes full screen width?
There was a problem hiding this comment.
Yeah, the caret still appears:
We also have a golden test to ensure the caret appears.
matthew-carroll
pushed a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperTextField] Re-generate failing caret test goldens. Resolves #2085
There are some failing tests related to caret rendering. These failures look like legitimate failures. However, comparing the master image with the test image, we can see that now the caret is better aligned with the toolbar (I draw a red line to demonstrate that).
Since these tests started to fail without any changes from our side, I assume that some caret related method in
RenderParagraphis now returning a different value.Master image:
Test image:
This PR updates the failing goldens.