-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed tracked-controls dependencies and replaced them with adding the component when a controller is detected. #287
Conversation
Thanks for the quick turnaround. Do you have a demo hosted somewhere to test this? What device is used to test? |
I tested locally with hp reverb controllers on moonrider |
@fordacious Thanks! We should add support for hp reverb on A-Frame itself. A new |
One more nit |
I'd be down to add hp reverb as a separate PR. |
Thanks! |
@fordacious Adding support for reverb on A-Frame should be easy. This is what we have to do.:
Thanks so much for looking into it. I've been meaning to add support but procrastinated since I don't have access to a device. |
Should enable generic controls. Previously the tracked-controls dependency would be added before generic controls and thus it would NOT set its controller properties when the controller was detected. Moving the tracked-controls addition to an event allows generic controls to set its properties, and thus the controller is correctly tracked.