Throw a custom JsonPathException instead of generic RuntimeException #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk6i
requested changes
Jul 11, 2021
mk6i
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
JsonPathExceptionthat is thrown on all occasions where we previously threw aRuntimeException. The logic is placed inexceptions.c, which allows easy re-use across the project using athrow_jsonpath_exception()function.The arginfo generation now makes use of the recent (?) addition of
@generate-class-entries. This slightly reduces the amount of boilerplate code injsonpath.c. Instead we get the code auto-generated into the arginfo files based on the class definitions in the stub. Yay!