Add some new calls #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add set_channel, get_current_channel and channel_list
Add channel_list, get_current_channel and set_channel
supersaiyanmode
approved these changes
Jan 4, 2020
| @@ -227,7 +244,7 @@ class ApplicationControl(WebOSControlBase): | |||
| "args": [], | |||
| "kwargs": {}, | |||
| "payload": {}, | |||
| "validity": lambda p: p.pop("returnValue"), | |||
| "validation": standard_validation, | |||
There was a problem hiding this comment.
This line had two separate super dumb mistakes. Thanks so much for fixing this.
|
Hi @dagavi, thanks so much for this PR. Let me know if there are more changes coming. If not, I'll merge your PR in. 👍 |
|
At this moment I will not make more changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
set_channel_with_id(string: channelID) # Opens the channel
channel_list: Returns all the channels
get_current_channel: Returns the current channel
get_current_program: Returns the curent channel + EPG data
Control:
play, pause, rewind, fastforward and stop
Add a try/catch in a import to have Python2 and Python3 support