Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify that reverse proxy setups need trusted-proxies #1127

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[docs] Clarify that reverse proxy setups need trusted-proxies #1127

merged 2 commits into from
Nov 23, 2022

Conversation

dequis
Copy link
Contributor

@dequis dequis commented Nov 23, 2022

This was referenced Nov 23, 2022
Closed
Closed
tsmethurst
tsmethurst reviewed Nov 23, 2022
View reviewed changes
docs/installation_guide/docker.md Outdated
To ensure [rate limiting](../api/ratelimiting.md) by IP works, remove the `#` in front of `GTS_TRUSTED_PROXIES` and set it to the IP the requests from the reverse proxy are coming from. That's usually the value of the `Gateway` field of the docker network.

```shell
$ docker network inspect gotosocial_gotosocial | jq -r '.[0].IPAM.Config[0].Gateway'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most people reading this likely won't have jq installed (or know what it is), so I think it's probably better to just show where in the json output you can find the gateway address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable!

@tsmethurst
Copy link
Contributor

Thanks! Just the one comment about jq

@tsmethurst
Copy link
Contributor

Grand, thank you very much! :)

@tsmethurst tsmethurst merged commit 8942a70 into superseriousbusiness:main Nov 23, 2022
@dequis dequis deleted the reverse-proxy-rate-limiting-docs branch November 23, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst tsmethurst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dequis @tsmethurst