-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] support configuring database caches #1246
[feature] support configuring database caches #1246
Conversation
…ation options Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
|
Signed-off-by: kim <grufwub@gmail.com>
…e config docs to example config Signed-off-by: kim <grufwub@gmail.com>
In time I want to add intelligent default for cache sizes. |
This lays the groundwork for any changes (if we decide to make them) in #1244 |
Nice one kim! this looks really good :) We gotta remember when we cut a release including these changes to include a migration note about the config format changing to allow nesting. Also, do you foresee any issues with the nesting? I mean, could it break if one provides a config that doesn't nest? |
for this specific PR there shouldn't be any breaking changes. the only nested values are new ones so shouldn't be an issue. for later PRs though -- I added a note about this in the issue #1244 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :) Just the one comment. Feel free to merge this after you've addressed it!
Description
CacheConfiguration{}
options to main configuration struct, allowing setting via config fileChecklist
go fmt ./...
andgolangci-lint run
.