Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Public list of suspended domains #1362

Merged
merged 9 commits into from
Jan 25, 2023
Merged

[feature] Public list of suspended domains #1362

merged 9 commits into from
Jan 25, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Jan 19, 2023

Description

Adds a opt-in config 'InstanceExposeSuspendedWeb' for serving a list of suspended domains on /about/suspended.
fixes #378

Ideally this will later be configurable in the settings interface, but that depends on #1360

image

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

NLnet Milestone 10.a: Page for displaying block lists (if instance allows showing it)

@f0x52 f0x52 added the enhancement New feature or request label Jan 19, 2023
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new page and its styling look really nice. Just a couple comments, lemme know what you think :)

internal/web/domain-blocklist.go Outdated Show resolved Hide resolved
web/source/settings/admin/emoji/local/overview.js Outdated Show resolved Hide resolved
web/template/domain-blocklist.tmpl Outdated Show resolved Hide resolved
@turtlegarden
Copy link
Contributor

this looks amazing! Until now I used a hacky solution and this looks much better

@f0x52
Copy link
Contributor Author

f0x52 commented Jan 25, 2023

Rebased, good to go now!

@f0x52 f0x52 requested a review from tsmethurst January 25, 2023 12:37
@f0x52 f0x52 mentioned this pull request Jan 25, 2023
9 tasks
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

internal/web/web.go Outdated Show resolved Hide resolved
internal/web/domain-blocklist.go Outdated Show resolved Hide resolved
@f0x52 f0x52 merged commit 17eecfb into main Jan 25, 2023
@f0x52 f0x52 deleted the public-blocklist branch January 25, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Opt-in public viewable instance suspension list
3 participants