Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Settings navigation design #1652

Merged
merged 16 commits into from
Mar 29, 2023
Merged

[frontend] Settings navigation design #1652

merged 16 commits into from
Mar 29, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Mar 28, 2023

Description

Headache refactor of the navigation menu structure, now featuring proper nesting and nicer design.
image

code to define routes/views
image

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.

@f0x52 f0x52 added the frontend Frontend-related stuff label Mar 28, 2023
@f0x52 f0x52 requested a review from tsmethurst March 29, 2023 09:04
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Not very cursed at all!

web/source/css/base.css Outdated Show resolved Hide resolved
web/source/settings/style.css Outdated Show resolved Hide resolved
web/source/settings/style.css Outdated Show resolved Hide resolved
web/source/settings/lib/navigation/util.js Show resolved Hide resolved
@tsmethurst tsmethurst merged commit 0746ef7 into main Mar 29, 2023
@tsmethurst tsmethurst deleted the settings-design branch March 29, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants