Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] process account delete side effects in serial, not in parallel #2360

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Nov 13, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request refines the account deletion process a little bit, to remove the deleted account's follow(er)s and statuses in serial rather than in parallel. This ought to help prevent worker exhaustion when importing a whole load of domain blocks at once, since previously each deleted status and follow was occupying a worker slot.

Some other small improvements as well, to delete things in a slightly more sensible order.

This PR partially addresses #2350 as well, by removing those calls to Enqueue within a function that was already enqueued. There's still some work to be done there, but it will require a more involved PR.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit 4ee436e into main Nov 14, 2023
3 checks passed
@tsmethurst tsmethurst deleted the account_delete_serial branch November 14, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants