[bugfix] process account delete side effects in serial, not in parallel #2360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refines the account deletion process a little bit, to remove the deleted account's follow(er)s and statuses in serial rather than in parallel. This ought to help prevent worker exhaustion when importing a whole load of domain blocks at once, since previously each deleted status and follow was occupying a worker slot.
Some other small improvements as well, to delete things in a slightly more sensible order.
This PR partially addresses #2350 as well, by removing those calls to Enqueue within a function that was already enqueued. There's still some work to be done there, but it will require a more involved PR.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.