Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Correctly handle range > content-length #2395

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Jadeiin
Copy link
Contributor

@Jadeiin Jadeiin commented Nov 29, 2023

Description

Hi I found this bug in Pleroma/Akkoma's MediaProxy. Currently GTS instance returns incorrect range headers when suffix length is larger than content-length:

$ url="https://goblin.technology/fileserver/01BPSX2MKCRVMD4YN4D71G9CP5/attachment/original/01E4BA3HFHWN7GDE2Y89F0J563.png"
$ curl -r 0-1048576 -X GET -I $url | grep Content-Range
Content-Range: bytes 0-1048576/11021

The correct range header should be bytes 0-11020/11021, which only requires formatting correct endRng when range > content-length.

Related issue(closed but not actually fixed): #1978

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Oh nice, thank you :)

@tsmethurst tsmethurst merged commit 2cc2645 into superseriousbusiness:main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants