-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Don't return Account or Status if new and dereferencing failed, other small fixes #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
changed the title
[bugfix] Don't return Account or Status if new and dereferencing failed
[bugfix] Don't return Account or Status if new and dereferencing failed, other small fixes
Jan 22, 2024
daenney
reviewed
Jan 22, 2024
daenney
reviewed
Jan 22, 2024
daenney
reviewed
Jan 22, 2024
daenney
reviewed
Jan 22, 2024
daenney
approved these changes
Jan 25, 2024
tsmethurst
added a commit
that referenced
this pull request
Feb 14, 2024
…ed, other small fixes (#2563) * tidy up account, status, webfingering logic a wee bit * go fmt * invert published check * alter resp initialization * get Published from account in typeutils * don't instantiate error for no darn good reason * shadow err * don't repeat error codes in wrapped errors * don't wrap error unnecessarily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes up some of our account and status dereferencing logic in the following ways:
AccountToAPIAccountPublic
when looking up account from Catodon #2514.published
property. This should allow the actual remote creation time of the account to be stored, instead of just the time that the GtS instance first saw the account, which was misleading in that it was making some accounts look way newer than they actually are./@username
).Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.