Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky e2e tests #777

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: flaky e2e tests #777

merged 3 commits into from
Dec 11, 2023

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Dec 11, 2023

Summary of change

I noticed "Successful signin with user input code in another tab" tab was flaky because the test wasn't waiting for successful signin in "another tab" before refreshing the "first tab". It might refresh the "first tab" before the signin was complete and in that case we wouldn't find .sessionInfo-user-id class. I have fixed that case in this PR by waiting for successful sign in in another tab first.

Test Plan

Ran tests locally.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Copy link

size-limit report 📦

Path Size
lib/build/index.js 14.46 KB (0%)
recipe/session/index.js 15.38 KB (0%)
recipe/session/prebuiltui.js 18.14 KB (0%)
recipe/thirdpartyemailpassword/index.js 30.17 KB (0%)
recipe/thirdparty/index.js 26.79 KB (0%)
recipe/emailpassword/index.js 10.23 KB (0%)
recipe/emailverification/index.js 7.47 KB (0%)
recipe/passwordless/index.js 63.9 KB (0%)
recipe/thirdpartypasswordless/index.js 83.92 KB (0%)
recipe/emailverification/prebuiltui.js 22.82 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 54.4 KB (0%)
recipe/thirdparty/prebuiltui.js 38.89 KB (0%)
recipe/emailpassword/prebuiltui.js 28.16 KB (0%)
recipe/passwordless/prebuiltui.js 103.01 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.18 KB (0%)
recipe/multitenancy/index.js 6.28 KB (0%)

@rishabhpoddar rishabhpoddar merged commit b05586f into 0.36 Dec 11, 2023
22 of 26 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/e2e-tests branch December 11, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants