Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve query params when redirectBack is used #779

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Dec 20, 2023

Summary of change

Previously, when calling redirectToAuth with the redirectBack option, query parameters were stripped when redirecting back to the previous page after authentication. This issue has been fixed, and now query parameters are preserved as intended.

Test Plan

Tested manually extensively. Also, updated an existing test case to verify query params are being preserved.

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Copy link

github-actions bot commented Dec 20, 2023

size-limit report 📦

Path Size
lib/build/index.js 14.49 KB (+0.22% 🔺)
recipe/session/index.js 15.41 KB (+0.18% 🔺)
recipe/session/prebuiltui.js 18.17 KB (+0.17% 🔺)
recipe/thirdpartyemailpassword/index.js 30.21 KB (+0.12% 🔺)
recipe/thirdparty/index.js 26.82 KB (+0.12% 🔺)
recipe/emailpassword/index.js 10.27 KB (+0.32% 🔺)
recipe/emailverification/index.js 7.5 KB (+0.4% 🔺)
recipe/passwordless/index.js 63.93 KB (+0.05% 🔺)
recipe/thirdpartypasswordless/index.js 83.96 KB (+0.05% 🔺)
recipe/emailverification/prebuiltui.js 22.86 KB (+0.15% 🔺)
recipe/thirdpartyemailpassword/prebuiltui.js 54.43 KB (+0.06% 🔺)
recipe/thirdparty/prebuiltui.js 38.92 KB (+0.09% 🔺)
recipe/emailpassword/prebuiltui.js 28.19 KB (+0.12% 🔺)
recipe/passwordless/prebuiltui.js 103.04 KB (+0.04% 🔺)
recipe/thirdpartypasswordless/prebuiltui.js 130.22 KB (+0.03% 🔺)
recipe/multitenancy/index.js 6.31 KB (+0.55% 🔺)

@anku255 anku255 changed the title Preserve query params when redirectBack is used fix: preserve query params when redirectBack is used Dec 20, 2023
@rishabhpoddar rishabhpoddar changed the base branch from master to 0.36 December 20, 2023 11:40
package.json Outdated Show resolved Hide resolved
test/end-to-end/signup.test.js Outdated Show resolved Hide resolved
lib/ts/utils.ts Show resolved Hide resolved
test/end-to-end/signup.test.js Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit 5caaa0d into 0.36 Dec 21, 2023
22 of 23 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/redirect-to-path branch December 21, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants