Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core call caching issue fix for nextjs apps #829

Merged
merged 2 commits into from
May 3, 2024

Conversation

rishabhpoddar
Copy link
Member

Summary of change

NextJS caches fetch calls that have GET requests, and as a result, a call to something like getRoles() may not return the most up to date info from the core. So we add the cache: "no-cache" arg when making fetch calls.

Discord link: https://discord.com/channels/603466164219281420/1234854984252788796/1234854984252788796

NextJS link: https://nextjs.org/docs/app/building-your-application/caching#data-cache

Test Plan

Added a test to make sure we are adding the no cache arg

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

@rishabhpoddar rishabhpoddar merged commit fd77d18 into 17.0 May 3, 2024
12 of 14 checks passed
@rishabhpoddar rishabhpoddar deleted the core-call-caching-issue-fix branch May 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant