Fallback to SK1 Transaction #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e purchased product may be `nil`
- Stores every purchased transaction by product if the transaction date of the purchased transaction is greater than the last stored transaction. Then when getting the latest transaction it defaults to SK2 and checks it has a transaction date within the last hour. If that fails, then it gets the lastInternalTransaction, i.e. the transaction that caused the internal purchase controller to mark the transaction as purchased. Otherwise, we fallback to getting the last transaction whose date is within the last hour. If that fails, we wait 500ms before trying again and finally returning nil. - When completing a purchase, a check is added that the productId of the purchase is the one being purchased. Also checks that the date of the purchase is within the last hour to stop old purchases from completing the purchase. - Fixes tests and swiftlint
… dismiss of paywallviewcontroller
Fixes issue where transactions other than purchased wouldn't call the completion block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
StoreTransactionassociated with the purchased product may benil. This stores every purchased transaction by product ID if the transaction date of the purchased transaction is > the last stored transaction. Then, when getting the latest transaction it defaults to SK2 and checks it has a transaction date within the last hour. If that fails, then it gets thelastInternalTransaction, i.e. the transaction that caused the internal purchase controller to mark the transaction as purchased. Otherwise, we fallback to getting the last transaction whose date is within the last hour. If that fails, we wait 500ms before trying again and finally returning nil.transactionDateof the purchase is within the last hour to stop old purchases from completing the purchase.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.swiftlintin the main directory and fixed any issues.