Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont throw exceptions to users #44

Merged
merged 5 commits into from
Mar 11, 2024
Merged

fix: dont throw exceptions to users #44

merged 5 commits into from
Mar 11, 2024

Conversation

jshah4517
Copy link
Member

@jshah4517 jshah4517 commented Mar 8, 2024

When an exception is thrown it falls through to the user's exception handler. This creates an unknown from the library perspective as the response may not match what we expect or introduce unexpected behaviour. We should return an absolute response to prevent that.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (a22df6b) to head (7720f42).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     99.65%   99.66%           
- Complexity       65       68    +3     
=========================================
  Files            15       15           
  Lines           290      296    +6     
=========================================
+ Hits            289      295    +6     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytestream bytestream merged commit 4c91a72 into master Mar 11, 2024
6 checks passed
@bytestream bytestream deleted the exceptions branch March 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants