Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Actions and Shortcuts to Replace RawKeyboard.instance.addListener(_handleKeyEvent) #24

Merged
merged 5 commits into from
Sep 10, 2022

Conversation

Satsrag
Copy link
Collaborator

@Satsrag Satsrag commented Sep 4, 2022

Using RawKeyboard.instance.addListener in MongolRenderEditable caused the Focus widget to fail to intercept keyboard events.

In Flutter latest version, this is replaced with Actions and Shortcuts. Most of code are copied from Flutter source.

There are still have some logic to test and discuss:

  • Implementation of computeLineMetrics method in MongolParagraph.
  • Find a way to swap up/down keys and left/right keys on Web.
  • Caret position is wrong when textAlign set to other MongolTextAlign.top.
  • Need further testing.

@suragch suragch merged commit 9ef38c2 into suragch:editor-fixes Sep 10, 2022
@suragch
Copy link
Owner

suragch commented Sep 10, 2022

Sorry again for my slow response time. I was traveling this last week. Hopefully this next week I'll be able to look at your work in more detail. Thank you!

@Satsrag
Copy link
Collaborator Author

Satsrag commented Sep 10, 2022

@suragch In fact, I should thank you first. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants