Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Macro.underscore() to convert to kebab case #51

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

lnr0626
Copy link
Collaborator

@lnr0626 lnr0626 commented Mar 2, 2020

Fixes #50

I'm not confident this is the correct solution as I know it doesn't support everything that Macro.underscore() does. I removed the 0-9 that I originally suggested in the issue as it caused one of the css class tests to fail

@msaraiva
Copy link
Member

msaraiva commented Mar 2, 2020

@lnr0626 thanks for the PR!

@lnr0626 lnr0626 deleted the fix/11/update-to_kebab_case branch March 2, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css_class transforms periods in class names into slashes
2 participants