-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop camelCase to kebab-case auto-conversion #62
Drop camelCase to kebab-case auto-conversion #62
Conversation
Why: * There are css architectures that use uppercase class names in their naming convention, for example, SUITCSS (https://suitcss.github.io/). Therefore we don't want to restrict that. This change addresses the need by: * Allowing binary or atom css classes to go through untouched, even in lists. When their defined as a property we lose control over exactly how it's going to be named and that can also be improved, but not as big of a deal. As a side note, I noticed that the project does not use `mix format`. Any particular reason?
Hi @zamith! Thanks for the PR. The camel case to kebab case auto-conversion will be removed very soon (before the next alpha version) so I believe the changes in this PR will no longer be necessary (please, let me know if it still does). The whole discussion can be found here.
Yeah, I have mixed feelings about the formatter. I think some of the decisions it makes are really bad, especially regarding indentation. However, I understand the importance of a unified format for all developers so I will eventually start using now as we starting to get more contributions. So I'll make sure I'll run it before releasing the next alpha version. Cheers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Marlus Saraiva <marlus.saraiva@gmail.com>
Co-Authored-By: Marlus Saraiva <marlus.saraiva@gmail.com>
@msaraiva Done. Also removed |
Why:
naming convention, for example, SUITCSS (https://suitcss.github.io/).
Therefore we don't want to restrict that.
This change addresses the need by:
lists. When they're defined as a property we lose control over exactly
how it's going to be named and that can also be improved, but not as
big of a deal.
As a side note, I noticed that the project does not use
mix format
.Any particular reason?