Support LV >= 0.20.10 #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>"
Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>"
Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>"
Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>"
Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>"
This was referenced Apr 8, 2024
tiagoefmoraes
added a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>
tiagoefmoraes
added a commit
that referenced
this pull request
Apr 9, 2024
--------- Co-authored-by: Gonzalo <456459+grzuy@users.noreply.github.com> Co-authored-by: marpo60 <952074+marpo60@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again 👋
In a previous PR, I though that the CI was not running correctly in latest LV.
After seeing the changes in Phoenix Live View 0.20.10 I can confirm that I was mistaken and the implementation of debug annotation in LV changed so surface needs to adjust accordingly
References:
Add HEEx debug annotations in 0.20.0
Move body annotation as a HTMLEngine callback in 0.20.10
Open questions:
Surface 0.11.2 is released already and in the mix.exs its support
~> 0.19.0 or ~> 0.20.0This is wrong in the sense that 0.11.2 is not able to run with 0.20.10. Not sure what we want to do there, maybe add something in the Changelog that explains this.Let me know what you think.