Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-drag doesn't work / sensitivity is off #22

Closed
baconpaul opened this issue Mar 18, 2022 · 10 comments · Fixed by #62
Closed

Multi-drag doesn't work / sensitivity is off #22

baconpaul opened this issue Mar 18, 2022 · 10 comments · Fixed by #62
Assignees

Comments

@baconpaul
Copy link
Contributor

Basically set first duration short and RMB drag that knob across the others - some reset but not enough. Console message that we are deleting something. Probably the modified DnD API got mis0-ported.

@baconpaul baconpaul self-assigned this Mar 18, 2022
@haenkel
Copy link
Contributor

haenkel commented Apr 17, 2022

Is this still happening for you?
works alright here.

just one mystery left:
in standalone the "drag-icon" disappears when dragging from left to right
but not when dragging from right to left.
resetting still works both ways.
(the delete message is just a debug out when you let go of the mouse)

@baconpaul
Copy link
Contributor Author

DragStillBugged

Sporadically yes. Here's a debug mac build at 8286441

@baconpaul
Copy link
Contributor Author

oh and of course I'm not mouse upping there.And sometimes it doesn't stop as you can see

@haenkel
Copy link
Contributor

haenkel commented Apr 17, 2022

  • The delete message still looks to be in sync with you loosing connection (mac mouse messages different? (broken cable? :) )
  • Is it the same when dragging from right to left?

Also no alpha render on linux, where you have transparency i get an opaque square.
rect

And how does it behave on windows? ( @mthierman could you try the above described? )

@baconpaul
Copy link
Contributor Author

Dragging the other direction it dismisses immediately many but not every time.

LikeSo

@baconpaul
Copy link
Contributor Author

Screen Shot 2022-04-17 at 7 55 44 PM

The stack looks like this

@baconpaul
Copy link
Contributor Author

Stopping in the debugger

 auto q = getTimerInterval();
    if (getTimerInterval() == GLOBAL_VALUE_HOLDER::getInstance()->LONG_MOUSE_DOWN_INTERVAL ||
        getTimerInterval() == 1)
    {
        is_a_long_mouse_down_event = true;
        _owner->on_long_mouse_down();
    }
    else
        _owner->on_mouse_up(*mouse_up_fake);

I see that the timer interval is 1000 and the LONG_HOLD interval is 750. Who knows why?

@baconpaul
Copy link
Contributor Author

Oh had and I know why and I have a fix. Hold on.

@mthierman
Copy link
Contributor

And how does it behave on windows? ( @mthierman could you try the above described? )

Seems to work fine on windows

baconpaul added a commit to baconpaul/b-step that referenced this issue Apr 18, 2022
The "RMB Drag" gesture on a mac trackpad is two fingers down,
click, drag. Cool. But 2 fingers down can also begin a wheel event.
The mac trackpad is smart enough to not send any motion but it does
generate a zero distance wheel event which B-Step picks up and uses
to interfere with the drag event. So don't start the wheel timer on
a zero distance wheel event.

Closes surge-synthesizer#22
@baconpaul
Copy link
Contributor Author

This is a mac only thing yeah. Here's the comment from my fixing PR #62

The "RMB Drag" gesture on a mac trackpad is two fingers down,
click, drag. Cool. But 2 fingers down can also begin a wheel event.
The mac trackpad is smart enough to not send any motion but it does
generate a zero distance wheel event which B-Step picks up and uses
to interfere with the drag event. So don't start the wheel timer on
a zero distance wheel event.

baconpaul added a commit that referenced this issue Apr 18, 2022
The "RMB Drag" gesture on a mac trackpad is two fingers down,
click, drag. Cool. But 2 fingers down can also begin a wheel event.
The mac trackpad is smart enough to not send any motion but it does
generate a zero distance wheel event which B-Step picks up and uses
to interfere with the drag event. So don't start the wheel timer on
a zero distance wheel event.

Closes #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants